-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eb/자주쓰이는 atom component 구현 및 molecule component 일부 구현 #98
Conversation
- date picker 컴포넌트 view 구현 - storybook test code 작성
- filter button 컴포넌트 view 구현 - story test code 작성 issue number: #68
- input 위에 붙일 label 컴포넌트 view 구현 - story test code 작성
- textarea 컴포넌트 view 구현 - story test code 작성 issue number: #76
- label tag 컴포넌트 view 구현 - story test code 작성 issue number: #72
- filter item title view 구현
- filter item description view 구현
- filter item color swatch view 구현
- filter item 중 label 부분 atom 조합하여 구현 - storybook test code 작성 issue number: #74
- input element style 공통 부분 같이 사용할 수 있도록 common style 로 따로 선언
background-color: ${({ theme }) => theme.palette.BG_COLOR01}; | ||
font-size: 0.8rem; | ||
color: ${({ theme }) => theme.palette.PRIMARY}; | ||
border-radius: 0.5rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
단위를 통일해 주셔서 좋습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
전체적으로 깔끔하게 잘 작성하신 것 같습니다.
import InputLabel from './InputLabel'; | ||
|
||
export default { | ||
title: 'Components/InputLabel', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
storybook 에서 한번 더 구분하는거 좋습니다 👍
client/src/components/molecules/filterItem/FilterItemLabel/FilterItemLabel.tsx
Outdated
Show resolved
Hide resolved
- 불필요한 파일경로 alias 수정
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
죠습니다 👍👍
atom component 구현 및 molecule component 일부 구현
atom component 구현
molecule component 일부 구현
#68 #72 #74 #76